Skip to content

Conversation

dscho
Copy link
Member

@dscho dscho commented Sep 26, 2024

Changes

This extends the Playwright tests to cover the 404 page.

Context

The 404 page is not only a place to tell the user that what they were looking for cannot be found, but also to guide them to what can be found, including the search box and the navigation box. It makes sense to guarantee that this keeps working as expected.

The 404 page is not only a place to tell the user that what they were
looking for cannot be found, but also to guide them to what _can_ be
found, including the search box and the navigation box.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho self-assigned this Sep 26, 2024
Copy link
Member

@ttaylorr ttaylorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, these tests are neat to be able to assert properties of the rendered page layout. Neat

@ttaylorr ttaylorr merged commit e635a81 into git:gh-pages Sep 26, 2024
1 check passed
@dscho dscho deleted the 404-page branch September 26, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants