Fix book redirects #1884
Merged
Fix book redirects #1884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
force-pushed
the
book-redirects
branch
2 times, most recently
from
cd4a670 to
5efd2fd
Compare
Instead of 404'ing, this URL should redirect to https://git-scm.com/book/en/v2 automatically, similarly the intermediate URL https://git-scm.com/book/en/. Analogous redirects are also needed for the translated versions of the book. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
I just fixed the `update-book2.rb` script so that URLs like https://git-scm.com/book/ (with a trailing slash) redirect again; This commit reflects the impact on the automatically rendered content files in `external/book/`. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
There is already code to handle the top-level URL correctly. However, URLs like http://localhost:5000/book/ still weren't handled by appending `index.html`. Let's fix this. This is needed because we are _just_ about to add tests to verify that the book redirects at URLs like https://git-scm.com/book/ work. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Now that `external/book/` has been re-generated, we can safely verify in the CI builds that these redirects keep working. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
book-redirects
branch
from
5efd2fd to
8781699
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This makes the following URLs redirect to the respective book front pages:
Context
By mistake, I typed in one of those URLs and was surprised to be redirected to the 404 page. Easy fix.