-
Notifications
You must be signed in to change notification settings - Fork 307
rn-116: minor copy edit #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm also overriding some previous edits, so perhaps some explanation is in order: 1. 079a323 changed some 'open-source' to 'open source', but not all and not consistently. Standard English uses dashed forms for adjectives and non-dashed forms for nouns; follow that rule. 2. 079a323 changed "people's" to "peoples'", which is not correct here (it would imply a number of ethnic groups is meant, but that's not the case); restore the original. (As an aside, personally I tend to leave the interviews alone beyond obvious typos, as I consider the language idiosyncrasies part of the glimpse into an interviewee's personality.)
|
Thanks for your fixes! They look good to me, especially the people's one. |
|
In addition to resolving the merge conflict, I deliberately added "the new" before the platform policy document link. |
|
@mjaix, oh it looks like you just merged it. Thanks! |
|
Not sure why the MR still wants to be merged though. Maybe we can just close it instead. |
|
It's closed now actually. Maybe it was a spurious GitHub bug? |
|
From a strict English point-of-view, the adjective is
written with a dash, so open-source software is an example
following that rule. With community and ecosystem,
however, I am not 100% sure whether "open source" is an
adjective or if we are talking of a compound noun - this
is a detail where my German background might lead me the
wrong way.
I don't see any difference (from a grammar or orthography
perspective) between "open-source X" with X being
"software", "community", "ecosystem" or another noun.
That said, the distinction is often simply not being made,
esp. in American usage, in that even the adjectives are
written without dashes, same as nouns. This is also
regularly the case in Git Rev News, and I usually leave
those alone (we're not publishing a book here; I mostly just
try to fix things that I find actually distracting or
influencing reading comprehension). This time I fixed your
edits because they were (in part) changing the (correct)
original into a less consistent (or even incorrect) state.
Thanks!
|
I'm also overriding some previous edits, so perhaps some
explanation is in order:
079a323 changed some 'open-source' to 'open source',
but not all and not consistently. Standard English uses
dashed forms for adjectives and non-dashed forms for nouns;
follow that rule.
079a323 changed "people's" to "peoples'", which is
not correct here (it would imply a number of ethnic groups
is meant, but that's not the case); restore the original.
(As an aside, personally I tend to leave the interviews
alone beyond obvious typos, as I consider the language
idiosyncrasies part of the glimpse into an interviewee's
personality.)