Open
Conversation
|
There are issues in commit b71b29d: |
1 similar comment
|
There are issues in commit b71b29d: |
|
There are issues in commit eee3b31: |
Hi, Johannes reported to me off-list that aggregation of test results doesn't work on GitHub Workflow when using Meson, as can be seen e.g. in [1]. As it turns out, the issue is that we don't set `TEST_OUTPUT_DIRECTORY` for many of the GitHub Workflows jobs. And because Meson by default puts test results into the build instead of into the source directory our assumption that the results can be found in "t/" is broken. This isn't I never noticed this failure myself because in GitLab we always set the above environment variable there. In any case, this patch fixes it as can be seen at [2]. Thanks! Patrick [1]: https://github.com/git-for-windows/git/actions/runs/14806194960/job/41574766327#step:9:2125 [2]: https://github.com/git/git/actions/runs/14833082023/job/41638408968 --- b4-submit-tracking --- # This section is used internally by b4 prep for tracking purposes. { "series": { "revision": 1, "change-id": "20250505-b4-pks-meson-aggregate-results-60ef175dd424", "prefixes": [] } }
Our CI needs to be aware of the location of the test output directory so that it knows where to find test results. Some of our CI jobs achieve this by setting the `TEST_OUTPUT_DIRECTORY` environment variable, which ensures that the output will be written to that directory. Other jobs, especially on GitHub Workflows, don't set that environment variable and instead expect test results to be located in the source directory in "t/". The latter logic does not work with Meson though, as the test results are not written into the source directory by default, but instead into the build directory. As such, any job that uses Meson without setting the environment variable will be unable to locate and aggregate results. Fix this by explicitly setting the test output directory when we set up the Meson build directory. Like this, we can easily default to "t/" in the source directory when the value hasn't been set explicitly. Reported-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Patrick Steinhardt <ps@pks.im>
pks-t
force-pushed
the
b4/pks-meson-aggregate-results
branch
from
eee3b31 to
c1896e5
Compare
|
There are issues in commit 69362f7: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test PR.