Fix isTestFile to correctly identify test files with words like lates… #591
+159
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t/fastest/greatest Fixed bug where test files like `services/github/commits/test_get_latest_remote_commit_sha.py` were incorrectly showing up in the coverage dashboard. The issue was that the function had two categories of patterns (strong and weak) but applied exclude patterns globally, causing legitimate test files to be excluded. Changes: - Separated test patterns into strong (unambiguous) and weak (can have false positives) - Strong patterns now return true immediately without exclusion checks - Weak patterns apply stricter exclusion filtering for false positives like latest.py - Added comprehensive test patterns from gitauto repo (snapshots, fixtures, configs, Storybook) - All 50 test cases pass with 143 assertions covering all patterns This ensures test infrastructure files are properly filtered from coverage results.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t/fastest/greatest
Fixed bug where test files like
services/github/commits/test_get_latest_remote_commit_sha.pywere incorrectly showing up in the coverage dashboard.The issue was that the function had two categories of patterns (strong and weak) but applied exclude patterns globally, causing legitimate test files to be excluded.
Changes:
This ensures test infrastructure files are properly filtered from coverage results.