-
Notifications
You must be signed in to change notification settings - Fork 7
Gitbucket color scheme #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Neiko2002 Thank you contributing. About color scheme, the appearance should be differ between the button and other badges for clearly to be able to click or not, imho. |
|
You are right the alignment is also a little bit of. But I was only referring to the color scheme. If we want to make it distinguishable from the other badges, we could use the design of the "+" button in the "files overview". Adding "btn btn-default" to the class of the button element above is sufficient. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you quickly fix!
I also tried adjusting alignments based on your styles then I wrote it each comments.
Please could you review it?
| padding: 2px 2px 0 5px; | ||
| right: 5px; | ||
| padding: 2px 0px 0 4px; | ||
| right: 15px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The icon content alignment when expanded is little bit off by these style.
And I think the button and badges should be aligned by center rather than right.
The below styles looks good for me.
padding: 0;
width: 25px;
height: 25px;
right: 10px;
| border-radius: 3px; | ||
| outline: none; | ||
| } | ||
| .root-expander > .octicon { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only width: 10px; is enough in this block for apply the style of btn-default and centering the icon contents.
|
I like your suggestions. The btn-default class would give the button a hover effect. We might want to add the effect if we don't want to use the class. |
|
I think it is better to use btn-default because it style provides us unified design. |
|
I've tried a smaller version of the expander button, having the same size as the other badges. I like this version the best. What do you think? |
|
Sorry for late reply. |
|
I have taken a look at the octotree design and changed my commit to resample it. How do you like it? |
|
It looks nice. Thank you for work! |
The design of the arrow icon in the explorer view is a little bit off. This PR adds the Gitbucket color scheme to the icon and removes the outlines when it is focused.