The "Keyboard shortcuts" option doesn't work

[JoyHak]

Version

0.14.18

Operating System

Windows

Distribution Method

msi (Windows)

Describe the issue

I can't change shortcuts. But I can use them in the app...

How to reproduce (Optional)

1. Open menu Help > Keyboard shortcuts
2. Nothing happens

Expected behavior (Optional)

1. Open menu Help > Keyboard shortcuts
2. See shortcut mappings

Relevant log output (Optional)

[Byron]

Thanks a lot for reporting!

When testing it I also didn't see anything in the console. Probably easy prey for @estib-vega, bug-hunter :).

[PavelLaptev]

@JoyHak Thanks for reporting this! The reason is a bit silly — the shortcuts modal only works in V3, and we didn’t add a check for V2, so it still shows up. I can take a look.

[JoyHak]

What is v2/v3? Is there an outdated component? :D

[PavelLaptev]

@JoyHak We're currently working on the new GitButler version — v3. You can check out the designs in Figma.

If you have any feedback, you can leave your comments there.

And also, you can switch to v3 from v2 by going to Global Settings (user preferences), or by using the hotkey and pressing v3.

[JoyHak]

Thanks, I'll try. In which version did the experimental options appear?

[JoyHak]

It's empty on Windows (stable and nightly version)

[Byron]

Sorry for the confusion: You can literally type v3 into any non-editable area of the UI and it will switch to the next major release.
I hope that works - I can confirm that the shortcuts show up when v3 is active.

[JoyHak]

I can confirm that the shortcuts show up when v3 is active.

Confirmed. I switched, it feels very different. But some of the design decisions I didn't understand.

The buttons are similar and make up the toolbar in a way. Why not put them on the panel on the left?

The changes made cannot be stretched/resized and they look like a ladder...

Why is there a grid here? It complicates the perception.

Nice feature, I can select the rows I want!

...What happened to the lines I didn't select?

Otherwise, the interface is quite convenient and adaptive! It's nice that Dicard Changes now works and I don't have to use Unapply and drop changes anymore... where is that button now?

This is masterpiece, no more opening the sidebar to perform an update!

[JoyHak]

You can check out the designs in Figma.

Look awesome! But I think the "Branches" & "Workspace" icons should match the rounded and smooth interface. I made sketches for the branches:

The workspace icon is tricky, as it needs to be simple and meaningful. I don't really like the desktop because no application in Mac & Win literally uses the desktop icon. So compiled various ideas related to file and commit work:

[PavelLaptev]

It's empty on Windows (stable and nightly version)

Interesting. This is probably something we’ll need to check before releasing V3 and ask people to try it out. (cc @krlvi)

[Byron]

I am amazed by your review, it's very valuable feedback, thanks so much!
Let me share what I know.

...What happened to the lines I didn't select?

When committing individual lines, these will go into the commit. This leaves the lines that weren't selected as changes, ready to go into another commit (or be explicitly discarded).

I would also expect the unselected lines to show up as uncommitted changes, but that didn't seem to be the case judging from the screenshots. If that's the case, it would be a grave bug.