isolate editor env in reword CLI tests#13023
Merged
Byron merged 1 commit intogitbutlerapp:masterfrom Mar 25, 2026
Merged
Conversation
Clear inherited GIT_EDITOR, VISUAL, and EDITOR in the shared test harness so CLI tests don't pick up the developer's shell settings. Othewise the test may fail as it tries to open the user editor under GIT_EDITOR which takes precedence. Co-authored-by: Sebastian Thiel <sebastian.thiel@icloud.com>
|
@codex is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes the but CLI test harness more hermetic by clearing inherited editor-related environment variables so tests don’t accidentally launch the developer’s configured editor.
Changes:
- Remove
GIT_EDITOR,VISUAL, andEDITORfrom the shared command environment isolation used by CLI tests. - Update the reword branch test to set
GIT_EDITORexplicitly (matching Git’s precedence rules).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/but/tests/but/command/reword.rs | Sets GIT_EDITOR in the test invocation so the harness-controlled editor script is always used. |
| crates/but-testsupport/src/prepare_cmd_env.rs | Extends environment isolation to remove editor env vars that can cause flaky or hanging tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clear inherited GIT_EDITOR, VISUAL, and EDITOR in the shared test harness so CLI tests don't pick up the developer's shell settings.
Othewise the test may fail as it tries to open the user editor under GIT_EDITOR which takes precedence.