Lite: keyboard shortcut fixes#13124
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Lite UI keyboard shortcut handling by adding modifier-aware shortcut parsing/matching (e.g. Shift+ArrowDown) and then adjusting workspace/branches keydown handlers and bindings to use the new semantics.
Changes:
- Add parsing/matching of shortcut strings with modifier keys in
apps/lite/ui/src/shortcuts.ts, and update shortcut formatting to include modifiers. - Update workspace selection shortcuts to use
Shift+ArrowUp/DownandShift+j/kfor section navigation, and simplify commit message editing key handling. - Adjust branches route keydown handler to ignore Shift-modified key events.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| apps/lite/ui/src/shortcuts.ts | Introduces modifier-aware shortcut parsing/matching and modifier-inclusive formatting for display. |
| apps/lite/ui/src/routes/project/$id/workspace/-WorkspaceShortcuts.ts | Updates workspace bindings to use explicit Shift-based shortcuts and removes the old modifier early-return to allow modifier-aware matching. |
| apps/lite/ui/src/routes/project/$id/branches/route.tsx | Extends the keydown early-return to ignore Shift-modified events in branches selection handling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.