Skip to content

Lite: keyboard shortcut fixes#13124

Merged
OliverJAsh merged 3 commits into
masterfrom
push-lsowvtzstkst
Mar 31, 2026
Merged

Lite: keyboard shortcut fixes#13124
OliverJAsh merged 3 commits into
masterfrom
push-lsowvtzstkst

Conversation

@OliverJAsh
Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI review requested due to automatic review settings March 31, 2026 16:08
@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
gitbutler-web Skipped Skipped Mar 31, 2026 4:09pm

Request Review

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Lite UI keyboard shortcut handling by adding modifier-aware shortcut parsing/matching (e.g. Shift+ArrowDown) and then adjusting workspace/branches keydown handlers and bindings to use the new semantics.

Changes:

  • Add parsing/matching of shortcut strings with modifier keys in apps/lite/ui/src/shortcuts.ts, and update shortcut formatting to include modifiers.
  • Update workspace selection shortcuts to use Shift+ArrowUp/Down and Shift+j/k for section navigation, and simplify commit message editing key handling.
  • Adjust branches route keydown handler to ignore Shift-modified key events.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
apps/lite/ui/src/shortcuts.ts Introduces modifier-aware shortcut parsing/matching and modifier-inclusive formatting for display.
apps/lite/ui/src/routes/project/$id/workspace/-WorkspaceShortcuts.ts Updates workspace bindings to use explicit Shift-based shortcuts and removes the old modifier early-return to allow modifier-aware matching.
apps/lite/ui/src/routes/project/$id/branches/route.tsx Extends the keydown early-return to ignore Shift-modified events in branches selection handling.

Comment thread apps/lite/ui/src/shortcuts.ts
@OliverJAsh OliverJAsh merged commit f1dc121 into master Mar 31, 2026
41 of 42 checks passed
@OliverJAsh OliverJAsh deleted the push-lsowvtzstkst branch March 31, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants