repo is preferred in our codebase#13691
Merged
Merged
Conversation
ICBA to typ repo unabrv.
krlvi
approved these changes
May 7, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes naming in the Rust rebase API by renaming SuccessfulRebase::repository() to SuccessfulRebase::repo(), aligning it with the existing Editor::repo() convention in but-rebase and the broader codebase’s “repo” terminology.
Changes:
- Renamed
SuccessfulRebaseaccessor fromrepository()torepo()inbut-rebase. - Updated
but-apicall sites to userebase.repo()when building preview/workspace state. - Updated uncommit flows to use the new accessor for dry-run preview paths.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/but-rebase/src/graph_rebase/mod.rs | Renames the SuccessfulRebase repository accessor to repo() to match existing conventions. |
| crates/but-api/src/workspace_state.rs | Updates workspace-state construction to call rebase.repo() for preview graphs. |
| crates/but-api/src/commit/uncommit.rs | Updates uncommit dry-run paths to use rebase.repo() / outcome.rebase.repo(). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ICBA to typ repo unabrv.
This is part 1 of 2 in a stack made with GitButler:
repois preferred in our codebase #13691 👈