Skip to content

repo is preferred in our codebase#13691

Merged
Caleb-T-Owens merged 1 commit into
masterfrom
caleb/repository-to-repo
May 7, 2026
Merged

repo is preferred in our codebase#13691
Caleb-T-Owens merged 1 commit into
masterfrom
caleb/repository-to-repo

Conversation

@Caleb-T-Owens
Copy link
Copy Markdown
Contributor

@Caleb-T-Owens Caleb-T-Owens commented May 7, 2026

ICBA to typ repo unabrv.


This is part 1 of 2 in a stack made with GitButler:

ICBA to typ repo unabrv.
Copilot AI review requested due to automatic review settings May 7, 2026 11:01
@github-actions github-actions Bot added the rust Pull requests that update Rust code label May 7, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes naming in the Rust rebase API by renaming SuccessfulRebase::repository() to SuccessfulRebase::repo(), aligning it with the existing Editor::repo() convention in but-rebase and the broader codebase’s “repo” terminology.

Changes:

  • Renamed SuccessfulRebase accessor from repository() to repo() in but-rebase.
  • Updated but-api call sites to use rebase.repo() when building preview/workspace state.
  • Updated uncommit flows to use the new accessor for dry-run preview paths.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
crates/but-rebase/src/graph_rebase/mod.rs Renames the SuccessfulRebase repository accessor to repo() to match existing conventions.
crates/but-api/src/workspace_state.rs Updates workspace-state construction to call rebase.repo() for preview graphs.
crates/but-api/src/commit/uncommit.rs Updates uncommit dry-run paths to use rebase.repo() / outcome.rebase.repo().

@Caleb-T-Owens Caleb-T-Owens enabled auto-merge May 7, 2026 11:09
@Caleb-T-Owens Caleb-T-Owens merged commit 9ee679e into master May 7, 2026
40 checks passed
@Caleb-T-Owens Caleb-T-Owens deleted the caleb/repository-to-repo branch May 7, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rust Pull requests that update Rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants