-
Notifications
You must be signed in to change notification settings - Fork 758
fix multi-stack commits #7976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
fix multi-stack commits #7976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@Byron is attempting to deploy a commit to the GitButler Team on Vercel. A member of the Team first needs to authorize it. |
This was referenced Apr 8, 2025
Closed
krlvi
added a commit
that referenced
this pull request
Apr 8, 2025
Revert "Merge pull request #7976 from Byron/fix-7952"
Byron
added a commit
that referenced
this pull request
Apr 28, 2025
- support for `GIT COMMITTER_DATE` overrides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As follow-up to #7952, this PR is another attempt at fixing it.
Whereas #7952 applies a fix as post-process, let's try again and see if this can be correct from the start.
Tasks
as the
base_substitutemust be set.The Problem
To reproduce the bug (with the previous fix unapplied), one has to be in a state where a new branch has been created, and now we attempt to create a new commit that new branch.
The current implementation isn't able to deal with that as it expect any head that is part of the worktree to already be merged into the worktree commit.