Add some setup utils for component testing #7991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- Centralize the test IDs into an enum - Add one for the branch name label component
The component tests sometimes require definition an Resize obeserver, which is not necessarily present in the global object. Expose a function that defined a stub for that
Add some mocks for the services so that
Add the @testing-library/user-events for better user interaction simulations in tests
The context menus and their items can take in test id strings
- Branch header - Header context menu & items - Rename modal
Modals can have test IDs as well, you know?
Just do some simple reactivity tests
estib-vega
force-pushed
the
component-testing
branch
from
d3688a5 to
024698e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⧓ Review in Butler Review
#9GlCFO04scomponent-testing
9 commit series (version 1)
Please leave review feedback in the Butler Review