Skip to content

21 implement settings modal input handling #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gitcoder89431 merged 2 commits into from
Aug 24, 2025
Merged

21 implement settings modal input handling #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb1f19d
feat: enhance settings modal input handling (#21)
gitcoder89431 Aug 24, 2025
49ebfab
fix: revert to S key for settings (better UX)
gitcoder89431 Aug 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/events.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,9 @@ impl EventHandler {
KeyCode::Char('q') => Ok(AppEvent::Quit),
KeyCode::Esc => Ok(AppEvent::CloseSettings),
KeyCode::Char('s') | KeyCode::Char('S') => Ok(AppEvent::OpenSettings),
KeyCode::Char('t') | KeyCode::Char('T') => Ok(AppEvent::ToggleTheme),
KeyCode::Up => Ok(AppEvent::NavigateUp),
KeyCode::Down => Ok(AppEvent::NavigateDown),
KeyCode::Enter => Ok(AppEvent::Select),
KeyCode::Up | KeyCode::Char('k') => Ok(AppEvent::NavigateUp),
KeyCode::Down | KeyCode::Char('j') => Ok(AppEvent::NavigateDown),
KeyCode::Enter | KeyCode::Char(' ') => Ok(AppEvent::Select),
KeyCode::Char('c')
if key_event.modifiers.contains(KeyModifiers::CONTROL) =>
{
Expand Down
9 changes: 4 additions & 5 deletions src/ui/app.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,9 +186,8 @@ impl App {
}
}
AppEvent::ToggleTheme => {
// Toggle theme through settings system
self.settings.get_mut().toggle_theme();
self.settings.get().apply_theme(&mut self.theme);
// T key functionality removed in Issue #21
// Theme changes now only available through settings modal
}
AppEvent::Resize(width, height) => {
self.last_size = Some((width, height));
Expand Down Expand Up @@ -371,11 +370,11 @@ impl App {

let footer_text = match self.state {
AppState::Main => format!(
"ESC/q: Quit | T: Toggle Theme | S: Settings | Current: [{}] | Production v0.1.0",
"ESC/q: Quit | S: Settings | Current: [{}] | Production v0.1.0",
current_theme
),
AppState::Settings => format!(
"ESC: Back to Main | T: Toggle Theme | Current: [{}] | Settings Mode",
"ESC: Back to Main | ↑↓/kj: Navigate | Enter/Space: Select | Current: [{}]",
current_theme
),
AppState::Quitting => "Application shutting down gracefully...".to_string(),
Expand Down