fix(VisibleLinesCount): Consider HScrollBar #56
Merged
+28
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes search hit being hidden by HScrollBar, also seen with git-grep
Proposed changes
TextView.FirstVisibleLine: Replace setter withSetFirstVisibleLinewhich considers
possibleHeightLossbecause the horizontal scrollbar might become visibleTextAreaControl.ScrollTo: CalculatecompletelyVisibleLinesCountand consider that the horizontal scrollbar might become visibleScreenshots
STR:
Before
After