Skip to content

pr-git-2339/HaraldNordgren/silence-catalog-output-under-make-s-v3

tagged this 21 Jun 14:56
The gitk and git-gui are noisy despite "make -s", quiet the builds.

Changes in v3:

 * Split the single combined commit into two, one per Makefile (gitk,
   git-gui)
 * gitk: gate the quiet helpers on -s in MAKEFLAGS and give the catalog rule
   a QUIET_MSGFMT prefix, so a silent build emits no MSGFMT/GEN lines
 * git-gui: replace the QUIET_MSGFMT0/QUIET_MSGFMT1 pair with a single
   QUIET_MSGFMT, since with --statistics gone there is no output left to
   reformat

Changes in v2:

 * Reworked from conditionally silencing msgfmt output under make -s to just
   removing --statistics outright, following 2f12b31b74 (Makefile: don't
   invoke msgfmt with --statistics, 2021-12-17)
 * Also drop gitk's Generating catalog echo, which is not needed either

Harald Nordgren (2):
  gitk: make "make -s" silent
  git-gui: silence statistics under "make -s"

 git-gui/Makefile  | 5 ++---
 gitk-git/Makefile | 6 ++++--
 2 files changed, 6 insertions(+), 5 deletions(-)

base-commit: 8d96f09e9245ddf80c1981476fcbac8c4bb4125f

Submitted-As: https://lore.kernel.org/git/pull.2339.v3.git.git.1782053803.gitgitgadget@gmail.com
In-Reply-To: https://lore.kernel.org/git/pull.2339.git.git.1781459539.gitgitgadget@gmail.com
In-Reply-To: https://lore.kernel.org/git/pull.2339.v2.git.git.1781995570677.gitgitgadget@gmail.com
Assets 2
Loading