Merged
Conversation
Frostman
requested review from
Copilot and
daniel-noland
and removed request for
a team
Contributor
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflows to use a unified set of registry credentials when logging into the image cache registry (run.h.hhdev.io:30000), replacing the previous LAB_REGISTRY_* secret names.
Changes:
- Switch cache-registry login secrets from
LAB_REGISTRY_USERNAME/LAB_REGISTRY_TOKENtoREGISTRY_USERNAME/REGISTRY_PASSWORDindev.yml. - Switch cache-registry login secrets from
LAB_REGISTRY_USERNAME/LAB_REGISTRY_TOKENtoREGISTRY_USERNAME/REGISTRY_PASSWORDinbump.yml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| .github/workflows/dev.yml | Updates cache-registry login credentials for both CI and publish jobs. |
| .github/workflows/bump.yml | Updates cache-registry login credentials for the scheduled dependency bump job. |
You can also share your feedback on Copilot code review. Take the survey.
.github/workflows/dev.yml
Outdated
Comment on lines
+150
to
+155
| @@ -151,8 +151,8 @@ jobs: | |||
| uses: "docker/login-action@v4" | |||
| with: | |||
| registry: "${{ env.CACHE_REGISTRY }}" | |||
| username: "${{ secrets.LAB_REGISTRY_USERNAME }}" | |||
| password: "${{ secrets.LAB_REGISTRY_TOKEN }}" | |||
| username: "${{ secrets.REGISTRY_USERNAME }}" | |||
| password: "${{ secrets.REGISTRY_PASSWORD }}" | |||
.github/workflows/dev.yml
Outdated
Comment on lines
+544
to
+549
| @@ -545,8 +545,8 @@ jobs: | |||
| uses: "docker/login-action@v4" | |||
| with: | |||
| registry: "${{ env.CACHE_REGISTRY }}" | |||
| username: "${{ secrets.LAB_REGISTRY_USERNAME }}" | |||
| password: "${{ secrets.LAB_REGISTRY_TOKEN }}" | |||
| username: "${{ secrets.REGISTRY_USERNAME }}" | |||
| password: "${{ secrets.REGISTRY_PASSWORD }}" | |||
.github/workflows/bump.yml
Outdated
Comment on lines
+35
to
+40
| @@ -36,8 +36,8 @@ jobs: | |||
| uses: "docker/login-action@v4" | |||
| with: | |||
| registry: "${{ env.CACHE_REGISTRY }}" | |||
| username: "${{ secrets.LAB_REGISTRY_USERNAME }}" | |||
| password: "${{ secrets.LAB_REGISTRY_TOKEN }}" | |||
| username: "${{ secrets.REGISTRY_USERNAME }}" | |||
| password: "${{ secrets.REGISTRY_PASSWORD }}" | |||
Frostman
force-pushed
the
dev/frostman/fix-reg-creds
branch
2 times, most recently
from
41c1ace to
9d97389
Compare
Signed-off-by: Sergei Lukianov <me@slukjanov.name>
Frostman
force-pushed
the
dev/frostman/fix-reg-creds
branch
from
9d97389 to
35fab8d
Compare
Signed-off-by: Sergei Lukianov <me@slukjanov.name>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.