Skip to content

Small fixes cli#1466

Merged
Fredi-raspall merged 2 commits intomainfrom
pr/fredi/cli-fixes
Apr 15, 2026
Merged

Small fixes cli#1466
Fredi-raspall merged 2 commits intomainfrom
pr/fredi/cli-fixes

Conversation

@Fredi-raspall
Copy link
Copy Markdown
Contributor

  • use better menu for completion
  • disable horrible coloring
  • exit on ctrl + D or ctrl + C

@Fredi-raspall Fredi-raspall requested a review from qmonnet April 15, 2026 10:10
@Fredi-raspall Fredi-raspall marked this pull request as ready for review April 15, 2026 10:10
@Fredi-raspall Fredi-raspall requested a review from a team as a code owner April 15, 2026 10:10
Copilot AI review requested due to automatic review settings April 15, 2026 10:10
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

@qmonnet qmonnet force-pushed the pr/fredi/cli-fixes branch from e3d3ab1 to d7a339d Compare April 15, 2026 11:44
@qmonnet
Copy link
Copy Markdown
Member

qmonnet commented Apr 15, 2026

Rebased on main to address the RUSTSEC issues that were blocking CI.

Copy link
Copy Markdown
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine by me. As discussed, My own preference would be to keep colours (ideally, with an improved colour scheme is the default one is not good) rather than no colours by default.

Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
The default coloring is pretty bad. I experimented with others,
but getting a good default is not trivial. Making it non-colored
provides the best UX.

Signed-off-by: Fredi Raspall <fredi@githedgehog.com>
@Fredi-raspall Fredi-raspall enabled auto-merge April 15, 2026 18:18
@Fredi-raspall Fredi-raspall added this pull request to the merge queue Apr 15, 2026
Merged via the queue into main with commit 2dab0c2 Apr 15, 2026
28 checks passed
@Fredi-raspall Fredi-raspall deleted the pr/fredi/cli-fixes branch April 15, 2026 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants