Skip to content

Conversation

@pau-hedgehog
Copy link
Contributor

No description provided.

@pau-hedgehog pau-hedgehog self-assigned this Nov 21, 2025
@pau-hedgehog pau-hedgehog requested a review from a team as a code owner November 21, 2025 11:01
@github-actions
Copy link

github-actions bot commented Nov 21, 2025

🚀 Deployed on https://preview-230--hedgehog-docs.netlify.app

Copy link
Contributor

@mrbojangles3 mrbojangles3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments inline

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive documentation for the integrated DHCP server feature in the Fabric user guide. The documentation covers configuration, management, and usage of DHCP services for VPC subnets.

  • Introduces complete DHCP server documentation with basic and advanced configuration examples
  • Documents static lease management via both VPC YAML and DHCPSubnet resources
  • Adds support for DHCP relay configuration with third-party DHCP servers

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
docs/user-guide/dhcp.md New comprehensive documentation covering DHCP server configuration, options, static leases, and relay support
docs/user-guide/.pages Adds dhcp.md to the navigation menu in the user guide

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Pau Capdevila <pau@githedgehog.com>
Signed-off-by: Pau Capdevila <pau@githedgehog.com>
Signed-off-by: Pau Capdevila <pau@githedgehog.com>
Copy link
Contributor

@mrbojangles3 mrbojangles3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the little typo in line 3, other than that it is good to merge, imo

Co-authored-by: Logan Blyth <mrbojangles3@users.noreply.github.com>
@pau-hedgehog
Copy link
Contributor Author

Just the little typo in line 3, other than that it is good to merge, imo

Thanks for the reminder. Fixed

@qmonnet
Copy link
Member

qmonnet commented Dec 17, 2025

Last commit misses the sign-off (and should probably be squashed with one of the previous commits anyway)

@Frostman Frostman merged commit cf85667 into master Dec 17, 2025
3 of 4 checks passed
@Frostman Frostman deleted the pau/dhcpd_user_guide branch December 17, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants