v0.0.8#3
Merged
Merged
Conversation
Bugfix release. Signed-off-by: Daniel Noland <daniel@githedgehog.com>
Just to make the linter happy. Signed-off-by: Daniel Noland <daniel@githedgehog.com>
Needed for many pcie passthrough setups Signed-off-by: Daniel Noland <daniel@githedgehog.com>
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project from version 0.0.7 to 0.0.8, incorporating kernel updates, dependency upgrades, and various code quality improvements. The changes focus on cleaning up redundant code patterns and enabling IOMMU support in the VM environment.
Key changes:
- Kernel version bump from 6.12.52 to 6.12.56 with updated clang 21.1.2
- IOMMU kernel command-line parameters added for hardware passthrough support
- Code style improvements removing redundant syntax patterns
- Multiple dependency version updates in Cargo.lock
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| n-vm/src/lib.rs | Added IOMMU kernel parameters, code cleanup (removed redundant return statements, format! calls, Default impl) |
| n-vm/Cargo.toml | Version bump to 0.0.8, removed duplicate "net" feature from tokio |
| n-vm-macros/Cargo.toml | Version bump to 0.0.8 |
| n-it/src/main.rs | Code cleanup: simplified closure syntax, removed redundant return |
| n-it/Cargo.toml | Version bump to 0.0.8 |
| linux/kernel.config | Updated kernel version to 6.12.56, clang to 21.1.2, disabled CONFIG_VIRTIO_VFIO_PCI |
| default.nix | Updated kernel version and SHA256 checksum |
| Cargo.toml | Updated proc-macro2, syn, and tokio dependency versions |
| Cargo.lock | Dependency lockfile updates reflecting version changes |
| .github/workflows/basic.yml | Updated Docker image tags to v0.0.8 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Daniel Noland <daniel@githedgehog.com>
Signed-off-by: Daniel Noland <daniel@githedgehog.com>
3d5ecc8 to
58911ea
Compare
Collaborator
Author
|
disabled the review requirement on a high pressure fix basis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixups to make CI work (hopefully)