Fix DRY_RUN always being true#30
Merged
zkoppert merged 2 commits intogithub-community-projects:mainfrom Jan 29, 2024
martincostello:issue-27
Merged
Fix DRY_RUN always being true#30zkoppert merged 2 commits intogithub-community-projects:mainfrom martincostello:issue-27
zkoppert merged 2 commits intogithub-community-projects:mainfrom
martincostello:issue-27
Conversation
zkoppert
reviewed
Jan 29, 2024
zkoppert
reviewed
Jan 29, 2024
Co-authored-by: Zack Koppert <zkoppert@github.com>
zkoppert
approved these changes
Jan 29, 2024
Collaborator
zkoppert
left a comment
zkoppert
left a comment
There was a problem hiding this comment.
Thanks @martincostello ! Appreciate the contribution! ✨
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Fix
DRY_RUNalways beingTrueProposed Changes
Fix
DRY_RUNalways being set toTrueregardless of whether the value is configured astrueorfalse.Fixes #27.
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducingReviewer
bug,documentation,enhancement,infrastructure, orbreaking