Conversation
Signed-off-by: Zack Koppert <zkoppert@github.com>
Collaborator
Author
|
@jmeridth Can add a test here if you are up for it and merge them together. |
jmeridth
approved these changes
Apr 2, 2024
- [x] change from splitting string to using datetime.datetime.fromisoformat since the format from GitHub API for a repositories created_at date is ISO 8601 (example: 2024-04-03T05:00:00Z) - [x] write tests to handle if the repo.created_at is a string or a datetime According to the github3.py library, the repository's [created_at date is a datetime.datetime obj](https://github.com/sigmavirus24/github3.py/blob/3bb730f11a70ab84f9f64835442dc4c9c62638ea/src/github3/repos/repo.py#L2938-L2941). This makes me wonder how we're getting a string. Signed-off-by: jmeridth <jmeridth@gmail.com>
Collaborator
|
@zkoppert I pushed up tests. I need to debug some more. The |
Collaborator
|
Have confirmed locally, the Looking at a couple more things and then will open this up for review and merge. |
repo.created_at is of type github3.repos.repo.ShortRepository which seems to have a created_at attribute of type string github3.repos.repo.Repository has a parsed created_at type of datetime.datetime object but that is not what we get back in collections Signed-off-by: jmeridth <jmeridth@gmail.com>
Collaborator
|
|
Signed-off-by: jmeridth <jmeridth@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Proposed Changes
fixes #82
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducingReviewer
bug,documentation,enhancement,infrastructure, orbreaking