fix: Performance fix to only measure statistics which are not hidden

[zkoppert]

fixes #177

Pull Request

Please review cautiously as my confidence around these changes is low as I was in a rush. Happy to pair on a review.

Proposed Changes

This pull request primarily focuses on enhancing the functionality of the issue_metrics.py script by introducing a new EnvVars class and using it to control the execution of certain metrics calculations. The changes allow for more flexibility in terms of what metrics to calculate and when.

Readiness Checklist

Author/Contributor

• If documentation is needed for this change, has that been included in this pull request
• run make lint and fix any issues that you have introduced
• run make test and ensure you have test coverage for the lines you are introducing

Reviewer

• Label as either bug, documentation, enhancement, infrastructure, or breaking

[zkoppert]

@jmeridth Any ideas on how to handle a default argument for the EnvVars type?

issue_metrics.py:130: error: Incompatible default for argument "env_vars" (default has type "None", argument has type "EnvVars") [assignment]

[jmeridth]

@jmeridth Any ideas on how to handle a default argument for the EnvVars type?

issue_metrics.py:130: error: Incompatible default for argument "env_vars" (default has type "None", argument has type "EnvVars") [assignment]

diff --git a/issue_metrics.py b/issue_metrics.py
index 628f7f3..85c3b39 100644
--- a/issue_metrics.py
+++ b/issue_metrics.py
@@ -127,7 +127,7 @@ def get_per_issue_metrics(
     ignore_users: Union[List[str], None] = None,
     max_comments_to_eval: int = 20,
     heavily_involved: int = 3,
-    env_vars: EnvVars = None,
+    env_vars: EnvVars = get_env_vars(),
 ) -> tuple[List, int, int]:
     """
     Calculate the metrics for each issue/pr/discussion in a list provided.

You could do some funky stuff with Union[EnvVars,None] as the return type from get_env_vars() but then you have to test for None everywhere it is used. Above is "easier". wdyt?

[zkoppert]

@jmeridth ready for next round of review when you have time

[jmeridth]

LGTM just one nit.