chore: add owner and repository names to errors#249
Merged
Conversation
jmeridth
force-pushed
the
jm-improve-error-message
branch
from
dc78fc2 to
a74d37c
Compare
zkoppert
approved these changes
Apr 23, 2024
Add owner and repository info to error messages Signed-off-by: jmeridth <jmeridth@gmail.com>
jmeridth
force-pushed
the
jm-improve-error-message
branch
from
a74d37c to
da4e827
Compare
Collaborator
Author
|
@zkoppert got rid of the duplicate code and went with a dictionary. Easier to set, access and default to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #234
Pull Request
Proposed Changes
Add owner and repository info to error messages
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducingReviewer
fix,documentation,enhancement,infrastructure, orbreaking