Merged
Conversation
Related to github/github-ospo#105 Only generate a release and new action container images if our semver related labels (`breaking`, `enhancement`, `fix`) or the `release` label are used on a merged pull request. Changed from push (merge) on main branch to release generation happening when a pull_request is merged to main branch. This gives us access to the pull requests labels without having to make API cals. Currently we'd still need to label a pull request with `release` if it is a dependabot or manual pull request related to a CVE or security fix. - [x] update CONTRIBUTING.md with new release information - [x] manually add `vuln` and `release` labels to repository - [x] add dependabot updates Signed-off-by: jmeridth <jmeridth@gmail.com>
jmeridth
force-pushed
the
jm-specific-labels-for-releases
branch
from
3b5cfd4 to
68a633a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to github/github-ospo#105
Closes #255
Closes #259
Pull Request
Proposed Changes
Only generate a release and new action container images if our semver related labels (
breaking,enhancement,fix) or thereleaselabel are used on a merged pull request.Changed from push (merge) on main branch to release generation happening when a pull_request is merged to main branch.
This gives us access to the pull requests labels without having to make API cals.
Currently we'd still need to label a pull request with
releaseif it is a dependabot or manual pull request related to a CVE or security fix.vulnandreleaselabels to repositoryReadiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducingReviewer
fix,documentation,enhancement,infrastructure,maintenance, orbreaking