Authenticate to GitHub Enterprise Server instances#91
Merged
Conversation
zkoppert
reviewed
Aug 2, 2023
Co-authored-by: Zack Koppert <zkoppert@github.com>
zkoppert
approved these changes
Aug 2, 2023
Collaborator
zkoppert
left a comment
zkoppert
left a comment
There was a problem hiding this comment.
Thanks for adding this and doing the testing as well! 🎉 Appreciate it! I plan to create a release later today.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolving #90
Simply checks the GITHUB_SERVER_URL environment variable, if it's set to github.com it will use the default login, otherwise it uses the GitHub Enterprise Server specific connection function.
Validated against my company's GitHub Enterprise Server instance, can't really show the output because of the proprietary nature of how the logs look. If there's a good bit of evidence you want for that that I can provide, let me know.