Skip to content

Fixing CI/CD workflow#18

Merged
imjohnbo merged 3 commits intogithub-developer:masterfrom
jonico:patch-2
Apr 8, 2021
Merged

Fixing CI/CD workflow#18
imjohnbo merged 3 commits intogithub-developer:masterfrom
jonico:patch-2

Conversation

@jonico
Copy link
Copy Markdown
Contributor

@jonico jonico commented Mar 12, 2021

  • use newer gcp setup action that uses new way of setting env variables

* use newer gcp setup action that uses new way of setting env variables
Copy link
Copy Markdown
Contributor

@imjohnbo imjohnbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@imjohnbo
Copy link
Copy Markdown
Contributor

imjohnbo commented Mar 29, 2021

@bharathkkb should we probably update this instead to google-github-actions/setup-gcloud, probably @v1? @jonico mind testing with that version?

* use google-github-actions/setup-gcloud
@jonico
Copy link
Copy Markdown
Contributor Author

jonico commented Mar 29, 2021

@imjohnbo: updated to the new namespace in latest commit, but I could not find a v1 tag over there, sticking with https://github.com/google-github-actions/setup-gcloud/tree/v0.2.1

The CI runs will fail until this PR gets merged as a forked PR does not get access to the GITHUB_TOKEN for the package registry.

@imjohnbo
Copy link
Copy Markdown
Contributor

@imjohnbo: updated to the new namespace in latest commit, but I could not find a v1 tag over there, sticking with https://github.com/google-github-actions/setup-gcloud/tree/v0.2.1

You're right – I could swear I had just seen a v1 🤔 👍

The CI runs will fail until this PR gets merged as a forked PR does not get access to the GITHUB_TOKEN for the package registry.

Yeah, I think we need to update some Google secrets too.... wondering if you could point me to a working run elsewhere to verify.

@imjohnbo
Copy link
Copy Markdown
Contributor

Ultimately I need to fix the CI 😀

@bharathkkb
Copy link
Copy Markdown
Contributor

@imjohnbo we havent cut a v1 yet. Waiting to clean up the old actions within current google-github-actions/setup-gcloud before we cut a v1.

@imjohnbo imjohnbo merged commit f6afd45 into github-developer:master Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants