Some changes for GKE#3
Merged
imjohnbo merged 2 commits intogithub-developer:masterfrom May 13, 2020
Merged
Conversation
Contributor
Author
|
@imjohnbo ci error seems to due to |
imjohnbo
suggested changes
May 8, 2020
Contributor
imjohnbo
left a comment
imjohnbo
left a comment
There was a problem hiding this comment.
Thanks so much for the pull request, @bharathkkb! Small request to keep TOKEN as-is or use a different name than GITHUB_TOKEN.
I think the CI won't pass just yet because it uses secrets and it came from a fork.
Contributor
Author
|
@imjohnbo thanks for the review, I will fix these up today :) |
docs: update README for Anthos usage fix: clean up workflow and use kustomize remove env check for now fix: docker auth fix: deploy CI: bump CI: bump chore: scale down replicas to 1 CI: bump chore: add echo statements for debugging fix: ubuntu 18 fix: let bin/installdependencies.sh take care of updates
bharathkkb
force-pushed
the
gke-improvements
branch
from
f9af7a8 to
185186c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #2
Changelist:
<owner>/<repo>