This repository was archived by the owner on Jun 24, 2024. It is now read-only.
Pass group ID to path to fix broken link #837
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These links were broken in stafftools. They were generating links like:
http://0.0.0.0:5000/stafftools/groups/groupslughereusing the slug instead of the ID.We could also change the controller to find the Group by slug instead, but the spec asserts it uses the ID so I'm guessing that's the behaviour we want.
@tarebyte
Error: