Skip to content
This repository was archived by the owner on Jun 24, 2024. It is now read-only.

Conversation

@nwoodthorpe
Copy link
Contributor

@nwoodthorpe nwoodthorpe commented Feb 5, 2017

These links were broken in stafftools. They were generating links like: http://0.0.0.0:5000/stafftools/groups/groupslughere using the slug instead of the ID.

We could also change the controller to find the Group by slug instead, but the spec asserts it uses the ID so I'm guessing that's the behaviour we want.

@tarebyte

Error:

ActiveRecord::RecordNotFound (Couldn't find Group):
app/controllers/stafftools/groups_controller.rb:11:in `set_group'

Copy link
Contributor

@tarebyte tarebyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tarebyte tarebyte merged commit 8468b5f into github-education-resources:master Feb 5, 2017
@nwoodthorpe nwoodthorpe deleted the broken_stafftools_group_link branch February 5, 2017 18:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants