Make Github.Issue.list options matter #166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I wanted closed issues (e.g. issues.list({state:"closed"}, cb)) and ended up with similar solution so I'd like PR merged up quickly |
Member
|
I'll take a look at this next chance I get. |
|
Thanks @Aendrew, looking forward to that |
Member
|
LGTM. Merging! 👍 |
Thanks for your efforts,
aendra-rininsland
pushed a commit
that referenced
this pull request
Apr 2, 2015
Make Github.Issue.list options matter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue.list takes options. With this patch, you can use these options to filter the issues wanted, e.g.
issues.list({"labels":"bug,ui"}, callback)
Before this patch, the options were sent as stringified data in the GET-request…