Updated markdown GFM test. #545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Also, if @DanielRuf updates their test, feel free to close this PR in lieu of that one. |
|
It seems there were also other changes or the API had issues. |
Member
Author
|
Yeah that should be covered in #544. If both are merged, I think the test suite passes. |
Merged
clayreimann
approved these changes
Apr 9, 2019
Member
clayreimann
left a comment
clayreimann
left a comment
There was a problem hiding this comment.
Failed on outdated node versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alternative to PR #501. I'm not sure if the response just changed within the past few days.
I think if we merge this in, and #544 , then tests will be passing.