Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a feature gate to skip cluster-scoped follower database commands during the rollout process. The change adds a guard condition that prevents GenerateFollowerChanges from executing any follower database change logic when follower cluster commands are not supported in the current context.
Key Changes:
- Added early return in
GenerateFollowerChangesmethod to skip follower change generation when not supported - Introduced
SupportsFollowerClusterCommands()helper method that currently returnsfalse - Added debug logging to indicate when follower changes are being skipped
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for disabling cluster-scoped follower commands by setting env var "DISABLE_FOLLOWER_COMMANDS=true".