Do not fail if single cluster apply fails#130
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the fault tolerance of the cluster orchestration process by adding error handling to prevent a single cluster failure from stopping the entire multi-cluster apply operation. When one cluster fails, the system now logs the error and continues processing remaining clusters, ensuring maximum coverage of change deployments.
Key Changes:
- Wrapped the cluster apply logic in a try-catch block to isolate failures
- Added CreateFailedClusterResult helper method to generate standardized error results
- Ensured all results (both successful and failed) are included in the return value
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ashleyvansp
approved these changes
Dec 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.