Add configurations for follower clusters #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdseaton
approved these changes
Jan 7, 2025
Contributor
There was a problem hiding this comment.
Copilot reviewed 5 out of 11 changed files in this pull request and generated 2 comments.
Files not reviewed (6)
- KustoSchemaTools/Parser/KustoWriter/DefaultDatabaseWriter.cs: Evaluated as low risk
- KustoSchemaTools/Model/Database.cs: Evaluated as low risk
- KustoSchemaTools/Changes/DatabaseChanges.cs: Evaluated as low risk
- KustoSchemaTools/KustoSchemaHandler.cs: Evaluated as low risk
- KustoSchemaTools/Model/FollowerCache.cs: Evaluated as low risk
- KustoSchemaTools/Model/FollowerPermissions.cs: Evaluated as low risk
Comments suppressed due to low confidence (1)
KustoSchemaTools/Changes/FollowerChange.cs:12
- [nitpick] The property EntityType should be marked as readonly to prevent unintended modifications.
public string EntityType { get; set; }
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
| public static FollowerDatabase LoadFollower(string databaseName, KustoClient client) | ||
| { | ||
| var follower = new FollowerDatabase { DatabaseName = databaseName }; | ||
| var metdaData = client.Client.ExecuteQuery(string.Format(FollowerMetadataQuery,databaseName)).As<FollowerMetadata>().First(); |
There was a problem hiding this comment.
The variable name 'metdaData' is misspelled. It should be 'metadata'.
Suggested change
| var metdaData = client.Client.ExecuteQuery(string.Format(FollowerMetadataQuery,databaseName)).As<FollowerMetadata>().First(); | |
| var metadata = client.Client.ExecuteQuery(string.Format(FollowerMetadataQuery,databaseName)).As<FollowerMetadata>().First(); |
| { | ||
| public string DatabaseName { get; set; } | ||
| public FollowerCache Cache { get; set; } = new FollowerCache(); | ||
| // TODO: No logic to load data / roll out changes implemented yet! |
There was a problem hiding this comment.
The TODO comment indicates that the logic to load data and roll out changes is not yet implemented. This should be addressed before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the option to configure hot cache, and the modification kinds for caching policies and permissions for follower clusters