Fix ups#3
Merged
aprilla merged 8 commits intogithub:masterfrom Oct 19, 2022
joshaber:joshaber/fixups
Merged
Conversation
joshaber
commented
Oct 14, 2022
| "customizations": { | ||
| "codespaces": { | ||
| "openFiles": [ | ||
| "build/app.js" |
Author
There was a problem hiding this comment.
build is the built artifacts, not the files they should edit, so we're ignoring them below and we should send them to ... I guess gameCoordinator.js? Or we could open both index.html and this?
Collaborator
There was a problem hiding this comment.
Good catch! gameCoordinator.js sounds like a good starting point to me.
joshaber
commented
Oct 14, 2022
| { | ||
| "portsAttributes": { | ||
| "8080": { | ||
| "3000": { |
Author
There was a problem hiding this comment.
Swapped to serve over http-serve below because I couldn't get http-serve to stop sending ETags, which meant it wasn't picking up my JS changes on reload.
joshaber
commented
Oct 14, 2022
| @@ -1,5 +1,5 @@ | |||
| const gulp = require('gulp'); | |||
| const sass = require('gulp-sass'); | |||
| const sass = require('gulp-sass')(require('sass')); | |||
Author
There was a problem hiding this comment.
I was getting an error from npx gulp without this.
aprilla
reviewed
Oct 18, 2022
aprilla
approved these changes
Oct 18, 2022
Collaborator
aprilla
left a comment
aprilla
left a comment
There was a problem hiding this comment.
One non-blocking nit, thanks for making these improvements! ✨
Co-authored-by: April Leonard <aprilla@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Annotated below