Skip to content
This repository was archived by the owner on Jun 21, 2023. It is now read-only.
This repository was archived by the owner on Jun 21, 2023. It is now read-only.

Ux Suggestions for inline comment view #1050

@ungb

Description

@ungb
  • If there are new remote commits, comment box says comments are disabled until I push (I have no local changes or commits). The remote commits don't change the file I'm currently on, so even if there are new remote commits, they shouldn't affect the ability to comment on diffs that haven't been affected

image

  • Promote to document from the diff view closes the comment box and doesn't do anything

  • Comment box padding is way too big
    image

  • The date in the comment title should be a link to the url of that comment, for sharing Allow navigation to comment on GitHub. #1074

  • Scrolling while comment box is open isn't feeling quite right. If there aren't any comments to scroll in the comment box, we should probably let the event bubble out to the diff/editor view so you can scroll the document without having to move the mouse away from the comment box. Addressed in Allow inline comment peek view to resize to content. #1112

  • There's no scrolling in the comment itself (if it's too long for the text box)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions