This repository was archived by the owner on Jun 21, 2023. It is now read-only.
WIP: Improve tracking of lines with inline-comments #1032
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added alternative diff line matching strategy based on the original line number and content.
This lets the user add whitespace/comments to line without losing inline-comments.
jcansdale
changed the title
Collaborator
Author
|
This was a naive "solution" to a hard problem. 😉 I hope one day we can find a decent solution! |
This was referenced Mar 23, 2018
jcansdale
force-pushed
the
feature/inline-reviews-matchline
branch
2 times, most recently
from
c0cc413 to
dd699f1
Compare
jcansdale
force-pushed
the
feature/inline-reviews-matchline
branch
from
dd699f1 to
6dc8aa0
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows new lines to be entered near to inline-comments without the comment mysteriously disappearing. It also allows lines with inline-comments to be commented out and still track the same line.
For posterity here is a pre-built VSIX from this branch: GitHub.VisualStudio.zip