This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Clone dialog - Dont disable filter while loading list of Repositories #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 18, 2016 21:43
…ialog. - Filterbox will be disabled if the loading fails, otherwise it will always be enabled.
Author
|
Looks like one of my unit tests failed. I will check why and update. |
Contributor
|
Yeah, it's failing here locally as well. |
Author
|
@grokys I corrected logic and fixed unit tests now :) |
grokys
reviewed
Sep 22, 2016
| filterTextIsEnabled = this.WhenAny(x => x.IsLoading, x => x.Value) | ||
| .Select(x => !x && repositories.UnfilteredCount > 0) | ||
| filterTextIsEnabled = this.WhenAny(x => x.IsLoading, | ||
| (loading) => loading.Value || repositories.UnfilteredCount > 0 && !LoadingFailed) |
Contributor
There was a problem hiding this comment.
Tiny nit: we usually don't put brackets around a single lambda parameter.
Author
There was a problem hiding this comment.
Let me correct this before you merge :)
Contributor
|
Thanks @danwalmsley LGTM! If you could merge the latest changes from master in, I can merge. |
added 3 commits
September 22, 2016 14:26
…s://github.com/danwalmsley/VisualStudio into clone-dialog-dont-disable-filter-while-loading
Author
|
Should be ready if you guys are happy :) |
Contributor
|
Merged 🎉 - thanks Dan! |
This was referenced Dec 6, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello all,
This PR addresses issues #108 and #517. I also added a few unit tests to cover this scenario.
:)