This repository was archived by the owner on Jun 21, 2023. It is now read-only.
Add support for F5 on VS 2017 #918
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building outside of VS, use the NuGet package tooling. When building inside VS, use the installed VS SDK version.
I don't think we need to copy Vsix extension files to a directory in the `GitHub.StartPage` project and then link `GitHub.StartPage.pkgdef` from `GitHub.VisualStudio`. It looks like there's a build in way.
jcansdale
force-pushed
the
build/917-fix-VS2017-F5
branch
from
9dd691b to
fec518c
Compare
jcansdale
changed the title
Collaborator
Author
|
Fixes #917 |
Collaborator
Author
|
@grokys This one has been working well for me and seems relatively low risk. Have you been using it? How do you feel about merging it? 😄 |
Collaborator
Author
|
@shana, I'm keen to get this one merged soon, so we can start using VS 2017 by default. I have been merging it with branches that I'm actively working on, but not having it makes reviewing PRs (and swapping between VS versions) a pain. 😉 |
shana
approved these changes
Mar 29, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables support for loading and running the solution on either VS 2015 or 2017.
When executing from Visual Studio it will use the installed tooling for the current version.
When executing outside of Visual Studio it will use the tooling installed with NuGet.
I still need to work out the finer details, but it works and I wanted to get a preview up.