-
Notifications
You must be signed in to change notification settings - Fork 523
[GHSA-6pfh-p556-v868] pnpm: Binary ZIP extraction allows arbitrary file write via path traversal (Zip Slip) #6729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GHSA-6pfh-p556-v868] pnpm: Binary ZIP extraction allows arbitrary file write via path traversal (Zip Slip) #6729
Conversation
|
Hi there @zkochan! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository. This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory |
|
If the goal was to flag all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR updates the security advisory for GHSA-6pfh-p556-v868 to correctly specify the fixed version range for the pnpm Zip Slip vulnerability. The change ensures that only versions prior to 10.28.1 are flagged as vulnerable, rather than all stable versions.
Changes:
- Updated the fixed version specification from
11.0.0-alpha.3to>=10.28.1 - Added database-specific metadata to document the last known affected version range
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| }, | ||
| { | ||
| "fixed": "11.0.0-alpha.3" | ||
| "fixed": ">=10.28.1" |
Copilot
AI
Jan 27, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'fixed' field should contain a single version number, not a version range with comparison operators. The value should be '10.28.1' without the '>=' prefix, as the field semantically indicates 'fixed in version X and later'.
| "fixed": ">=10.28.1" | |
| "fixed": "10.28.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense, but I don't have permissions to apply this suggestion... 🤷🏻♂️
|
I don't understand where 11.0.0-alpha.3 is coming from. In the advisory I only specified this: No mention of 11.0.0-alpha.3 |
|
@zkochan I am also wondering. The link to the GitHub Advisory Database version is GHSA-6pfh-p556-v868 and you can see the wrong version there. But at the bottom it says "zkochan published to pnpm/pnpm 2 days ago" and that has correct versions... |
4f81ab3
into
mgol/advisory-improvement-6729
|
Hi @mgol! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future! |
Updates
Comments
See GHSA-6pfh-p556-v868. The issue is fixed in pnpm
10.28.1and currently this advisory flags all versions older than11.0.0-alpha.3which means all stable versions of pnpm are flagged.