[GHSA-884p-74jh-xrg2] Command Injection in tree-kill#7455
Closed
Wenxin-Jiang wants to merge 1 commit intoWenxin-Jiang/advisory-improvement-7455from
Closed
[GHSA-884p-74jh-xrg2] Command Injection in tree-kill#7455Wenxin-Jiang wants to merge 1 commit intoWenxin-Jiang/advisory-improvement-7455from
Wenxin-Jiang wants to merge 1 commit intoWenxin-Jiang/advisory-improvement-7455from
Conversation
github-actions
Bot
changed the base branch from
main
to
Wenxin-Jiang/advisory-improvement-7455
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
CVE-2019-15599 is exploitable only through the Windows branch
exec('taskkill /pid ' + pid + ' /T /F'), which was first added in0.0.4whenprocess.platform === 'win32'support was introduced.Versions
0.0.1–0.0.3are Unix-only and invokespawn('ps', [...])exclusively—argv form, no shell, no attacker-controlled string interpolation—so the vulnerable sink does not exist.Fix commit
deee138a(1.2.2) guards the sameexeccall withparseInt/Number.isNaN, confirming it as the sole sink.