Skip to content

[Bug] "Variable modes" appear in asset panel for some components #19

@janmaarten-a11y

Description

@janmaarten-a11y

Description

Some components (mostly Details and some Utilities) show "variable modes" as options when previewing them in the Figma asset panel. This is typically caused by a direct reference to a Primer Web library variable, or an embedded instance of a component like an Octicon.

Impact

This needs to be resolved before actual dark mode support can be considered. If left as-is and dark mode is added, users would see two sets of variable modes, which would be confusing.

Possible approaches

  • May require direct support from Figma to address at the tool level. We've cleaned up a lot of references manually, and there may be some that can't be found.
  • May require recreating affected components from the ground up to remove direct references to Primer Web library variables. We've had to detach a number of Octicon components, for instance.

Metadata

Metadata

Labels

bugSomething doesn't look right or isn't behaving correctlyset:allLibrary-wide component updates

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions