fix: remove invalid tool aliases from Ember agent#1355
Merged
codemillmatt merged 1 commit intogithub:stagedfrom Apr 10, 2026
Merged
fix: remove invalid tool aliases from Ember agent#1355codemillmatt merged 1 commit intogithub:stagedfrom
codemillmatt merged 1 commit intogithub:stagedfrom
Conversation
The tools field used non-standard names (codebase, terminalCommand, fetch_webpage) that are not recognized as valid tool aliases. Per the custom agents configuration docs, unrecognized tool names are silently ignored, which effectively gave Ember zero tools. Removing the tools field entirely enables all available tools by default, which is the correct behavior for a general-purpose AI partner agent. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
🔍 Skill Validator Results2 resource(s) checked | ✅ All checks passed Full output
|
Contributor
There was a problem hiding this comment.
Pull request overview
Removes outdated/invalid tool aliases from the Ember agent definition so the agent is not left without usable tools due to unrecognized tool names.
Changes:
- Deleted the
toolsfrontmatter entry fromagents/ember.agent.mdto rely on default tool availability.
jmprieur
approved these changes
Apr 9, 2026
codemillmatt
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Ember agent (
agents/ember.agent.md) specifies tools using outdated VS Code-era names:yaml tools: ["codebase", "terminalCommand", "fetch_webpage"]Per the GitHub docs on custom agent tools, unrecognized tool names are silently ignored. The valid aliases are:
read,edit,search,execute/shell,web,agent,todo.Since none of the three specified names are valid, the platform ignores all of them — effectively giving Ember zero tools. This makes Ember unable to read files, run commands, search, or do anything beyond conversation.
Fix
Remove the
toolsfield entirely. When omitted, the agent gets all available tools by default — which is the correct behavior for Ember as a general-purpose AI partner.Verification
droidagent which uses valid aliases:tools: ["read", "search", "edit", "shell"]toolsenables all toolsNote
The
CONTRIBUTING.mdexample also uses the same outdated tool names (codebase,terminalCommand). That may warrant a separate fix.