Fix security-review skill discovery#1515
Conversation
🔍 Skill Validator Results
Summary
Full validator output```text Found 1 skill(s) [security-review] 📊 security-review: 2,051 BPE tokens [chars/4: 2,269] (detailed ✓), 15 sections, 0 code blocks [security-review] ⚠ No code blocks — agents perform better with concrete snippets and commands. ✅ All checks passed (1 skill(s)) ``` |
There was a problem hiding this comment.
Pull request overview
Addresses skill discoverability on the Awesome Copilot skills website by enriching both the skill’s trigger phrasing and the website’s generated search metadata so searches like security-review and /security-review match reliably.
Changes:
- Add explicit
security-reviewand/security-reviewtrigger terms to thesecurity-reviewskill description. - Expand generated website search metadata for skills to include id/name/path/category (via a precomputed
searchTextfield). - Regenerate the
docs/README.skills.mdentry for the updated skill description.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| skills/security-review/SKILL.md | Adds direct trigger phrases to improve matching for security-review-style queries. |
| eng/generate-website-data.mjs | Includes richer skill search text (id/name/path/category/description) and uses it in search-index.json. |
| docs/README.skills.md | Updates the generated README table row to reflect the new description text. |
aaronpowell
left a comment
There was a problem hiding this comment.
Reviewing this PR, I think it's more solving the symptom (this skill doesn't return) rather than the problem (search isn't doing any weighting on results).
I think it'd be better to evaluate the search logic and look to add some weighting into fields (title match > description match) and perform some ordering in the results (sort by match not just alphabetical).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
6cf7a0a to
128442e
Compare
@aaronpowell, I updated this PR description. The fix is not on weighting yet, but adding enough "search fields" for discovery now. |
|
I'll commit this as an interim fix, but I'm going to be revising the website search in general shortly. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Problem
security-reviewis published, but exact slug searches likesecurity-reviewwere unreliable because generated skill search metadata only guaranteed the display title and description.What changed
This keeps the old search inputs and adds the missing ones in generated website data.
Security Reviewsecurity-reviewname, e.g.security-reviewskills/security-reviewmetadata.nameis the raw skill name fromSKILL.md(security-review).skill.titleis the generated display title (Security Review). The generatedsearchTextnow includes both, so existing queries likeSecurity,Review, andSecurity Reviewdo not regress, while exact slug/path queries now work too.No
skills/security-review/SKILL.mddescription change is needed anymore; the generator now indexes the skill name/path directly. Without this generator change, a skill could work around the issue by repeating its slug in the description, but that should not be required.Validation
npm run website:datanpm run skill:validatenpm run website:buildgit diff --checkskills.jsonincludesSecurity Review,security-review, andskills/security-reviewin searchable metadataFixes #1513