Fix modal close button on samples page#706
Merged
aaronpowell merged 1 commit intomainfrom Feb 12, 2026
Merged
Conversation
The samples page never called setupModal(), so the close button, Escape key, and backdrop click handlers were never registered. Add the missing setupModal() call matching all other pages.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the modal dialog on the samples page could not be dismissed. The root cause was a missing setupModal() call during page initialization, which prevented event handlers for the close button, Escape key, and backdrop click from being registered.
Changes:
- Added
setupModalimport from../modalmodule - Added
setupModal()call ininitSamplesPage()to register modal event handlers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The modal dialog on the samples page cannot be dismissed — the close button, Escape key, and backdrop click all fail to close it.
Root cause
The samples page (
samples.ts) dynamically importsopenFileModalto display recipe content, but never callssetupModal(). This function registers all the event handlers for closing the modal (close button click, Escape key, backdrop click). Every other page that uses the modal callssetupModal()during initialization.Fix
Add the missing
setupModal()call toinitSamplesPage(), matching the pattern used by all other pages (agents, prompts, instructions, collections, hooks, skills, index).Testing
Verified with Playwright: