Use rake-compiler #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosmn
force-pushed
the
cmn/gemspec
branch
2 times, most recently
from
4d2ef3c to
46bc43a
Compare
Don't reinvent this particular wheel. There's still a mention or two of `.bundle` which is what we have on OS X. So some of the cleaning up just did not work on anything else.
The actually-large payload is too large to be of particular use.
|
@carlosmn were you waiting on anything else here? I'd love to have this merged :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cleanup only actually worked on OS X, where you have
.bundleinstead of.so. The test where we swap out to ruby in the middle of a benchmark still doesn't work correctly on anything else, but meh. We should probably just delete that logic./cc @brianmario who was interested in this