Skip to content

Fix documentation: Match @target names with template data-target#95

Merged
smockle merged 1 commit intogithub:mainfrom
Scipion:fix-action-example
Dec 10, 2020
Merged

Fix documentation: Match @target names with template data-target#95
smockle merged 1 commit intogithub:mainfrom
Scipion:fix-action-example

Conversation

@Scipion
Copy link
Copy Markdown
Contributor

@Scipion Scipion commented Dec 9, 2020

In the current example in the docs appears:
data-target="hello-world.name to be matched with @target nameTarget: HTMLElement
where it should be @target name: HTMLElement.
and something similar for the target "output"

@Scipion Scipion requested a review from a team as a code owner December 9, 2020 15:48
Copy link
Copy Markdown
Contributor

@smockle smockle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Nice catch, thanks for your contribution!

(Related: #92)

@smockle smockle merged commit 8b5c917 into github:main Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants