Conversation
Results are not sensitive. The same results may be obtained by cloning this public repo and running 'npx lhci autorun', or by running Lighthouse via the Google Chrome DevTools against the public site. Terms: https://github.com/GoogleChrome/lighthouse-ci/blob/master/docs/services-disclaimer.md#temporary-public-storage
This resolves 'Could not find 'bundler'', according to actions/runner-images#1976
koddsson
approved these changes
Dec 10, 2020
Contributor
koddsson
left a comment
koddsson
left a comment
There was a problem hiding this comment.
This is neat! I'd love to get the issues fixed and merge this PR.
* fix: Lighthouse audit issues * chore: Skip Lighthouse checks which fail in CI but not DevTools * chore: Cache Bundler gems to speed-up CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lighthouse CI is a CLI version of Lighthouse, which can be used to assess site performance, accessibility, best practices and SEO.
This PR add a Lighthouse CI check to incoming pull requests, so we can automate the kinds of checks @koddsson performed here.
We can set thresholds for specific categories or exclude them. PWA rules are currently excluded.
NB: As configured, results are uploaded to temporary public storage. Results are not sensitive. The same results may be obtained by cloning this public repo and running
npx lhci autorun, or by running Lighthouse via the Google Chrome DevTools against the public site.