Skip to content

allow naked boolean arguments in test helpers #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bhuga merged 1 commit into from
Sep 23, 2016
Merged

allow naked boolean arguments in test helpers #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/chatops/controller/test_case_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@ def extract_named_params(command_string)
arg = command_string[last_index..-1]
matches = arg.match(/ --(\S+)(.*)/)
params[matches[1]] = matches[2].strip
params[matches[1]] = "true" unless params[matches[1]].present?
command_string = command_string.slice(0, last_index)
end

Expand Down
7 changes: 7 additions & 0 deletions spec/lib/chatops/controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,13 @@ def ensure_app_given
expect(chatop_response).to eq "You can deploy foobar just fine."
end

it "works with boolean arguments" do
chat "where can i deploy foobar --this-is-sparta", "bhuga"
expect(request.params["action"]).to eq "wcid"
expect(request.params["user"]).to eq "bhuga"
expect(request.params["params"]["this-is-sparta"]).to eq "true"
end

it "anchors regexes" do
expect {
chat "too bad that this message doesn't start with where can i deploy foobar", "bhuga"
Expand Down