Merged
Conversation
Contributor
Verified docs bug. Our other behavior also doesn't have quotes. https://github.com/bhuga/hubot-chatops-rpc/blob/master/src/chatops-rpc.coffee#L79 This looks great. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an actual signature with sample public and private keys for implementors to use for testing. I added some strategic
putsin thechatops_controllertest suite to get this information out.This also fixes a small discrepancy with the way the
Chatops-Signatureheader is constructed. The parsing code doesn't parse quotes out, so I figured that was correct behavior. If quotes are optional (and stripped out somewhere I'm not seeing), I'll make that clear in the spec and fix it in my implementation too.