Add support for mention_slug parameter#31
Merged
mistydemeo merged 1 commit intomasterfrom Sep 18, 2017
Merged
Conversation
Currently, the protocol assumes that the GitHub login supplied will always be the appropriate username to use to refer to the user in chat messages. This isn't always a safe assumption. The motivating factor for this change is Slack's recent change to usernames: https://api.slack.com/changelog/2017-09-the-one-about-usernames However, it's also possible to imagine other systems in which a user's GitHub username is distinct from their chat username; providing this field should support a wider variety of possible usecases.
jbarnette
approved these changes
Sep 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the protocol assumes that the GitHub login supplied will always be the appropriate username to use to refer to the user in chat messages. This isn't always a safe assumption.
The motivating factor for this change is Slack's recent change to usernames: https://api.slack.com/changelog/2017-09-the-one-about-usernames
However, it's also possible to imagine other systems in which a user's GitHub username is distinct from their chat username; providing this field should support a wider variety of possible usecases.